Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove api.CustomElementRegistry.define.disabledFeatures_static_property from BCD #22007

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

queengooborg
Copy link
Contributor

This PR removes the define.disabledFeatures_static_property member of the CustomElementRegistry API from BCD. I cannot figure out what this feature is referring to, and have not been able to put together a working test.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CustomElementRegistry/define/disabledFeatures_static_property

…rty from BCD

This PR removes the `define.disabledFeatures_static_property` member of the `CustomElementRegistry` API from BCD. I cannot figure out what this feature is referring to, and have not been able to put together a working test.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CustomElementRegistry/define/disabledFeatures_static_property
@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jan 26, 2024
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbamberg removed the docs for it in mdn/content#29317. It was first introduced in mdn/content#8228.

Will, should we remove the BCD as the content doesn't talk about this feature anymore (and I assume the content was removed purposefully)?

@wbamberg
Copy link
Contributor

@wbamberg removed the docs for it in mdn/content#29317. It was first introduced in mdn/content#8228.

Will, should we remove the BCD as the content doesn't talk about this feature anymore (and I assume the content was removed purposefully)?

The old page for define() had some quite complex examples that I simplified in mdn/content#29317, but it looks like I inadvertently removed this example as well. But it should probably be in https://developer.mozilla.org/en-US/docs/Web/API/Element/attachShadow instead, right?

What happens, I think, is that if your element has a static disabledFeatures property, and it is an array containing "shadow", then https://developer.mozilla.org/en-US/docs/Web/API/Element/attachShadow will throw. I've checked this in Firefox and Chrome.

It is in the spec at: https://html.spec.whatwg.org/multipage/custom-elements.html#element-definition.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wbamberg!
I think we should move this under api.Element.attachShadow.disabledFeatures_static_property then.

@queengooborg queengooborg marked this pull request as draft February 11, 2024 23:25
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Sep 10, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Sep 11, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 18, 2024
@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Nov 26, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot added size:m [PR only] 25-100 LoC changed and removed merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. labels Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants