-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove api.CustomElementRegistry.define.disabledFeatures_static_property from BCD #22007
base: main
Are you sure you want to change the base?
Conversation
…rty from BCD This PR removes the `define.disabledFeatures_static_property` member of the `CustomElementRegistry` API from BCD. I cannot figure out what this feature is referring to, and have not been able to put together a working test. Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CustomElementRegistry/define/disabledFeatures_static_property
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbamberg removed the docs for it in mdn/content#29317. It was first introduced in mdn/content#8228.
Will, should we remove the BCD as the content doesn't talk about this feature anymore (and I assume the content was removed purposefully)?
The old page for What happens, I think, is that if your element has a static It is in the spec at: https://html.spec.whatwg.org/multipage/custom-elements.html#element-definition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wbamberg!
I think we should move this under api.Element.attachShadow.disabledFeatures_static_property
then.
This pull request has merge conflicts that must be resolved before it can be merged. |
…tures_static_property/removal
This pull request has merge conflicts that must be resolved before it can be merged. |
…tures_static_property/removal
This pull request has merge conflicts that must be resolved before it can be merged. |
…tures_static_property/removal
This PR removes the
define.disabledFeatures_static_property
member of theCustomElementRegistry
API from BCD. I cannot figure out what this feature is referring to, and have not been able to put together a working test.Tests Used: https://mdn-bcd-collector.gooborg.com/tests/api/CustomElementRegistry/define/disabledFeatures_static_property