-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Firefox data for datalist HTML element #21533
base: main
Are you sure you want to change the base?
Update Firefox data for datalist HTML element #21533
Conversation
This PR updates and corrects version values for Firefox and Firefox Android for the `datalist` HTML element. This adds a note that the describes the behavior I discovered during testing, which is important to mention as developers may think the feature is unsupported otherwise. Fixes mdn#17753.
html/elements/datalist.json
Outdated
@@ -18,7 +18,10 @@ | |||
"firefox": { | |||
"version_added": "4", | |||
"partial_implementation": true, | |||
"notes": "The <code><datalist></code> element will only create a dropdown for textual types, such as <code>text</code>, <code>search</code>, <code>url</code>, <code>tel</code>, <code>email</code> and <code>number</code>. The <code>date</code>, <code>time</code>, <code>range</code> and <code>color</code> types are not supported." | |||
"notes": [ | |||
"Firefox does not display a downwards-pointing arrow or any other UI change to indicate a dropdown is present. The user will have to double-click on the input to show the dropdown.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is specific to the "text-like" input types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For confirmation purposes, could you state a type that does have the dropdown arrow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I can't. But for example for you get the tick marks. But I guess we could leave it like that for cases where a dropdown would be expected?
html/elements/datalist.json
Outdated
"notes": "The <code><datalist></code> element will only create a dropdown for textual types, such as <code>text</code>, <code>search</code>, <code>url</code>, <code>tel</code>, <code>email</code> and <code>number</code>. The <code>date</code>, <code>time</code>, <code>range</code> and <code>color</code> types are not supported." | ||
"notes": [ | ||
"Firefox does not display a downwards-pointing arrow or any other UI change to indicate a dropdown is present. The user will have to double-click on the input to show the dropdown.", | ||
"The <code><datalist></code> element will only create a dropdown for textual types, such as <code>text</code>, <code>search</code>, <code>url</code>, <code>tel</code>, <code>email</code> and <code>number</code>. The <code>date</code>, <code>time</code>, <code>range</code> and <code>color</code> types are not supported." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pre-existing: But Firefox supports lists for range and color (on some platforms)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know which platforms in particular?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Range: all-platforms are supported.
Color: supported on Linux/Windows, not supported on macOS/Android (https://bugzilla.mozilla.org/show_bug.cgi?id=1805397)
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
This PR updates and corrects version values for Firefox and Firefox Android for the
datalist
HTML element. This adds a note that the describes the behavior I discovered during testing, which is important to mention as developers may think the feature is unsupported otherwise. Fixes #17753.