Addition of missing devtools details #20403

rebloor · 2023-07-23T10:58:40Z

Summary

Add details, previously missing for devtools features not supported in Firefox

Related issues

PR Remove browser-specific references in "Extend the developer tools" article content#28132 containing the Extend the developer tools article update
PR
Complete devtools.inspectedWindow content#28131 containing complementary updates to complete devtools.inspectedWindow documentation coverage
PR Complete devtools.panels content#28223 containing complementary update to complete devtools.network documentation coverage

Fixes #16859

Rob--W

Question: why are some features of edge not a mirror of Chrome?

rebloor · 2023-07-27T23:20:17Z

@Rob--W

Question: why are some features of edge not a mirror of Chrome?

Because I missed updating them from the copied content. I will fix that.

webextensions/api/devtools.json

github-actions · 2023-10-27T12:44:28Z

This pull request has merge conflicts that must be resolved before it can be merged.

queengooborg · 2023-11-07T11:09:15Z

Hey @Rob--W, looks like this has been waiting on your review for a while!

Rob--W · 2023-11-07T16:00:45Z

While I'm not against adding explicit entries for API support statuses in the BCD, the BCD also link to MDN documentation that haven't been merged yet.

I am reluctant to merge these MDN articles, because they document Chrome-only behavior. It's my intent to revisit these PRs eventually, but it's a low priority for me.

Elchi3 · 2023-11-10T14:03:46Z

Should we try to get a Chrome reviewer for this one?

Rob--W · 2023-11-10T20:23:49Z

That's not necessary. I am familiar with this API in both Firefox and Chrome.

The difficulty here is presenting the content in a way such that it is obvious which parts are cross-browser and which ones are Chrome-only. The current documentation lists the least common denominator, so anyone who relies on that can build an extension that works across browsers.

If we add the Chrome-specific bits here as well, then I'm concerned that an extension dev would try out the documentation and then become disappointed when they discovered that the documented features don't actually work in Firefox.

queengooborg · 2023-11-11T00:40:56Z

I think that so long as the browser compatibility data is up to date, then we should be fine on that front. Web extensions don't have a standard specification that we can refer to, so since browsers are free to implement what they want to, I wouldn't expect much cross-browser support anyways.

rebloor · 2023-11-13T03:09:50Z

Also addresses #16859

github-actions · 2024-03-08T16:23:45Z

This pull request has merge conflicts that must be resolved before it can be merged.

queengooborg · 2024-05-11T15:30:58Z

This PR has been sitting around in need of a review for a while, and is the second oldest PR open. We should get this reviewed and landed, or close it!

Rob--W · 2024-05-12T18:45:09Z

I think that it is okay for BCD notes to be added, even without mdn documentation. @rebloor could you update the PR and tag dotproto for review? If there is anything that requires my attention, please pm me.

dotproto

LGTM

dotproto · 2024-07-01T20:59:22Z

webextensions/api/devtools.json

+              "mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/devtools/inspectedWindow/resource",
+              "support": {
+                "chrome": {
+                  "version_added": true


I tried to figure out when this and the other compact entries were added in Chromium, but unfortunately I ran out of history to inspect. The most concrete thing I can say is that this is the earliest commit I see where onResourceAdded and other such properties are exposed in third_party/closure_compiler/externs/chrome_extensions.js. That commit landed in m68. Based on some testing of old Chromium versions, it seem to be older than that, but I can't determine how much older because I haven't been able to get a Chromium build older than 68 to run locally.

Closure compiler is not the right reference for when it was introduced. It merely added typing.

Considering that Resource specifies the type of getResources, it is safe to use the same version as getResources.

@dotproto @Rob--W It looks like it was added in chromium/chromium@e975d11, i.e. 22.0.1223.0, before Chrome 22 (22.0.1229). Or is this only when the docs landed? 🤔

dotproto · 2024-07-01T21:02:54Z

webextensions/api/devtools.json

+                "chrome": {
+                  "version_added": true
+                },
+                "edge": "mirror",


@rebloor, does "mirror" automatically indicate that this only came in after Edge adopted Chromium?

@dotproto That is my understanding

I can confirm this.

webextensions/api/devtools.json

dotproto · 2024-07-01T21:51:43Z

webextensions/api/devtools.json

+                "mdn_url": "https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/devtools/panels/SourcesPanel/onSelectionChanged",
+                "support": {
+                  "chrome": {
+                    "version_added": true


This appears to be from before Chrome 21 as the reference to this file existed before the oldest historical entry on chrome/common/extensions/api/devtools/panels.json.

github-actions · 2024-08-04T21:23:12Z

This pull request has merge conflicts that must be resolved before it can be merged.

Co-authored-by: Simeon Vincent <[email protected]>

github-actions · 2024-08-09T03:10:34Z

This pull request has merge conflicts that must be resolved before it can be merged.

caugner · 2024-12-03T19:59:48Z

@rebloor Since this PR updates support data for Chromium, Firefox, and Safari, and we seem to be differently certain about each of the browsers, how about we split this up and extract Chromium/Safari changes into two separate PRs? I think it'll be easier to land it that way.

PS: Meanwhile eef1292 has added some Chromium data for the devtools API.

Addition of missing devtools details

f7390dc

rebloor added the data:webext Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Jul 23, 2023

rebloor requested a review from Rob--W July 23, 2023 10:58

rebloor self-assigned this Jul 23, 2023

This was referenced Jul 23, 2023

Complete devtools.inspectedWindow mdn/content#28131

Open

Remove browser-specific references in "Extend the developer tools" article mdn/content#28132

Open

Added details for panels

75eb6da

Rob--W reviewed Jul 27, 2023

View reviewed changes

rebloor mentioned this pull request Jul 27, 2023

Complete devtools.panels mdn/content#28223

Open

Update edge to mirror

989deb1

Rob--W reviewed Aug 8, 2023

View reviewed changes

webextensions/api/devtools.json Show resolved Hide resolved

webextensions/api/devtools.json Show resolved Hide resolved

rebloor added 2 commits August 9, 2023 12:07

Merge branch 'main' into add-missing-devtools-details

8e03c69

Update for feedback

1b1619e

rebloor marked this pull request as ready for review August 9, 2023 02:09

rebloor requested a review from Rob--W August 9, 2023 02:09

github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Oct 27, 2023

Merge branch 'main' into add-missing-devtools-details

6ca6037

github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Oct 27, 2023

github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 8, 2024

Merge branch 'main' into add-missing-devtools-details

f8156d6

github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label May 15, 2024

rebloor added 2 commits May 15, 2024 12:23

Update devtools.json

119aa98

fix issues

8142621

rebloor requested a review from dotproto May 15, 2024 02:01

updates to mdn_url

13be084

dotproto approved these changes Jul 1, 2024

View reviewed changes

github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 4, 2024

rebloor and others added 2 commits August 9, 2024 11:48

Apply suggestions from review

b949f01

Co-authored-by: Simeon Vincent <[email protected]>

Merge branch 'main' into add-missing-devtools-details

a3bcb75

github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 8, 2024

Linter requested mdn_uil fixes

5e82c2f

github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 9, 2024

Merge branch 'main' into add-missing-devtools-details

5b6d234

github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Aug 9, 2024

queengooborg marked this pull request as draft August 28, 2024 13:44

rebloor marked this pull request as ready for review September 13, 2024 18:47

rebloor and others added 4 commits September 14, 2024 06:48

Merge branch 'main' into add-missing-devtools-details

f8548a8

Merge branch 'main' into add-missing-devtools-details

7c367d6

Merge branch 'main' into add-missing-devtools-details

d7a5277

Merge branch 'main' into add-missing-devtools-details

4e7f9f4

github-actions bot added the size:l [PR only] 101-1000 LoC changed label Nov 22, 2024

Merge branch 'main' into add-missing-devtools-details

1e3d193

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addition of missing devtools details #20403

Addition of missing devtools details #20403

rebloor commented Jul 23, 2023 •

edited

Loading

Rob--W left a comment

rebloor commented Jul 27, 2023 •

edited by queengooborg

Loading

github-actions bot commented Oct 27, 2023

queengooborg commented Nov 7, 2023

Rob--W commented Nov 7, 2023

Elchi3 commented Nov 10, 2023

Rob--W commented Nov 10, 2023

queengooborg commented Nov 11, 2023

rebloor commented Nov 13, 2023

github-actions bot commented Mar 8, 2024

queengooborg commented May 11, 2024

Rob--W commented May 12, 2024

dotproto left a comment

dotproto Jul 1, 2024

Rob--W Jul 1, 2024

caugner Nov 22, 2024

dotproto Jul 1, 2024 •

edited

Loading

rebloor Aug 8, 2024

caugner Nov 22, 2024

dotproto Jul 1, 2024

github-actions bot commented Aug 4, 2024

github-actions bot commented Aug 9, 2024

caugner commented Dec 3, 2024

Addition of missing devtools details #20403

Are you sure you want to change the base?

Addition of missing devtools details #20403

Conversation

rebloor commented Jul 23, 2023 • edited Loading

Summary

Related issues

Rob--W left a comment

Choose a reason for hiding this comment

rebloor commented Jul 27, 2023 • edited by queengooborg Loading

github-actions bot commented Oct 27, 2023

queengooborg commented Nov 7, 2023

Rob--W commented Nov 7, 2023

Elchi3 commented Nov 10, 2023

Rob--W commented Nov 10, 2023

queengooborg commented Nov 11, 2023

rebloor commented Nov 13, 2023

github-actions bot commented Mar 8, 2024

queengooborg commented May 11, 2024

Rob--W commented May 12, 2024

dotproto left a comment

Choose a reason for hiding this comment

dotproto Jul 1, 2024

Choose a reason for hiding this comment

Rob--W Jul 1, 2024

Choose a reason for hiding this comment

caugner Nov 22, 2024

Choose a reason for hiding this comment

dotproto Jul 1, 2024 • edited Loading

Choose a reason for hiding this comment

rebloor Aug 8, 2024

Choose a reason for hiding this comment

caugner Nov 22, 2024

Choose a reason for hiding this comment

dotproto Jul 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Aug 4, 2024

github-actions bot commented Aug 9, 2024

caugner commented Dec 3, 2024

rebloor commented Jul 23, 2023 •

edited

Loading

rebloor commented Jul 27, 2023 •

edited by queengooborg

Loading

dotproto Jul 1, 2024 •

edited

Loading