Refactor porous electrode #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update plot_nyquist to new plotting argument since the old one does not work anymore.
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] * Update README.md --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Matt Murbach <[email protected]>
…k#255) * modifies equation for TLMQ element, fixes ECSHackWeek#253 * fix equation for Zs
* add Zarc element
* docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
* add readthedocs template * add packaged requirements to docs building config * update intersphinx_mapping * split documentation requirements into separate file and update doc building config
* replace travisCI build badge with github actions * add package requirements to docs config becuase they are needed to build docs pages
…hon 3.7 support (ECSHackWeek#306) * Add pandas requirement, change numpy requirement to 1.22.4 * Update README.md * Update minimum Python version to 3.8 * Remove Python 3.7 from test and deploy workflow * Fix flake8 linting: missing whitespace * Update test_circuit_elements.py Fix flake8 ignore lines that are causing the linter to fail * Update test_preprocessing.py Add space causing the linter to fail --------- Co-authored-by: Matt Murbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as described in adds B/2 term to Paasch element, fixes #251