Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pref64 lifetime fix #46

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Pref64 lifetime fix #46

merged 3 commits into from
Oct 8, 2024

Conversation

furry13
Copy link
Contributor

@furry13 furry13 commented Oct 2, 2024

See #45

@tomfitzhenry
Copy link

Woo!

I'm running this on my home network (with default timers), and can see PREF64 lifetime is now 30 minutes, as expected.

Between this PR and #48, my Android devices now manage to keep their CLAT address. Previously, they would get a CLAT address, then lose it after 5-10 minutes.

Copy link
Owner

@mdlayher mdlayher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@mdlayher
Copy link
Owner

mdlayher commented Oct 7, 2024

Looks like we need a quick gofmt here.

gofmt -w internal/plugin/plugin.go
@furry13
Copy link
Contributor Author

furry13 commented Oct 8, 2024

Looks like we need a quick gofmt here.

oops, sorry, fixed.

@mdlayher mdlayher merged commit 7358f69 into mdlayher:main Oct 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants