Fix the test workflow

mdaines · Feb 4, 2025 · 2eb7a3c · 2eb7a3c
1 parent 3d137cc
commit 2eb7a3c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,6 +1,9 @@
-name: Test
+name: Run xcodebuild test
 
-on: workflow_dispatch
+on:
+  push:
+    branches-ignore:
+      - website
 
 jobs:
   build:
@@ -48,6 +51,7 @@ jobs:
       - uses: actions/upload-artifact@v4
         with:
           path: test.xcresult
+          name: test.xcresult
 
       - name: Clean up keychain
         if: ${{ always() }}

diff --git a/ReviewCount.xcodeproj/project.pbxproj b/ReviewCount.xcodeproj/project.pbxproj
@@ -260,15 +260,15 @@
 				DEVELOPMENT_TEAM = A5VF6CDK3T;
 				GENERATE_INFOPLIST_FILE = YES;
 				IPHONEOS_DEPLOYMENT_TARGET = 18.2;
-				MACOSX_DEPLOYMENT_TARGET = 15.2;
+				MACOSX_DEPLOYMENT_TARGET = 14.6;
 				MARKETING_VERSION = 1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = net.slowscan.ReviewCountTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SDKROOT = auto;
-				SUPPORTED_PLATFORMS = "iphoneos iphonesimulator macosx xros xrsimulator";
+				SUPPORTED_PLATFORMS = macosx;
+				SUPPORTS_MACCATALYST = NO;
 				SWIFT_EMIT_LOC_STRINGS = NO;
 				SWIFT_VERSION = 5.0;
-				TARGETED_DEVICE_FAMILY = "1,2,7";
 				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ReviewCount.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/ReviewCount";
 				XROS_DEPLOYMENT_TARGET = 2.2;
 			};
@@ -283,15 +283,15 @@
 				DEVELOPMENT_TEAM = A5VF6CDK3T;
 				GENERATE_INFOPLIST_FILE = YES;
 				IPHONEOS_DEPLOYMENT_TARGET = 18.2;
-				MACOSX_DEPLOYMENT_TARGET = 15.2;
+				MACOSX_DEPLOYMENT_TARGET = 14.6;
 				MARKETING_VERSION = 1.0;
 				PRODUCT_BUNDLE_IDENTIFIER = net.slowscan.ReviewCountTests;
 				PRODUCT_NAME = "$(TARGET_NAME)";
 				SDKROOT = auto;
-				SUPPORTED_PLATFORMS = "iphoneos iphonesimulator macosx xros xrsimulator";
+				SUPPORTED_PLATFORMS = macosx;
+				SUPPORTS_MACCATALYST = NO;
 				SWIFT_EMIT_LOC_STRINGS = NO;
 				SWIFT_VERSION = 5.0;
-				TARGETED_DEVICE_FAMILY = "1,2,7";
 				TEST_HOST = "$(BUILT_PRODUCTS_DIR)/ReviewCount.app/$(BUNDLE_EXECUTABLE_FOLDER_PATH)/ReviewCount";
 				XROS_DEPLOYMENT_TARGET = 2.2;
 			};