Added missing MCUBOOT_VERSION_TWEAK in Zephyr port #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nordicjm
approved these changes
Jan 13, 2025
|
It looks like I'm expected to add "Signed-off-by" to commit message, is that correct? |
Yes, i.e. |
m5k8
force-pushed
the
add-zephyr-app-tweak
branch
from
66457e7 to
e24d4a8
Compare
|
OK, corrected. |
|
Still failing? I can't see why, I added sign-off clause, and I can see it's there in the patch. |
|
You have: |
Signed-off-by: Michael Konieczny <[email protected]>
m5k8
force-pushed
the
add-zephyr-app-tweak
branch
from
e24d4a8 to
9d522d5
Compare
|
Good eye! Thank you. Corrected, again. |
de-nordic
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several components in Zephyr app VERSION file and assignment of VERSION_TWEAK/APP_TWEAK to MCUBOOT_VERSION_TWEAK was missing, causing MCUBOOT_VERSION_TWEAK to be 0 all the time.