Two new themes, a stylesheet, and old theme updates OH MY! #528
Conversation
Two new themes: Aquamarine and Pastel. One new CSS stylesheet: Luminous
Add new themes and new stylesheet to new themes and previous themes I added
| --shadow-sm: 0 2px 4px rgba(0, 0, 0, 0.5); | ||
| --shadow-md: 0 4px 6px rgba(0, 0, 0, 0.6); | ||
| --shadow-lg: 0 10px 15px rgba(0, 0, 0, 0.7); | ||
|
|
There was a problem hiding this comment.
the bottom of this file is wonked out
src/Core/WebServer.cs
Outdated
| @@ -97,8 +97,10 @@ public void PreInit() | |||
| RegisterTheme(new("cyber_swarm", "Cyber Swarm", ["/css/themes/cyber_swarm.css"], true)); | |||
| RegisterTheme(new("punked", "Punked", ["/css/themes/punked.css"], true)); | |||
| RegisterTheme(new("eyesear_white", "Eyesear White", ["/css/themes/eyesear_white.css"], false)); | |||
| RegisterTheme(new("swarmpunk", "Swarm Punk", ["/css/themes/modern.css", "/css/themes/swarmpunk.css"], true)); | |||
| RegisterTheme(new("beweish", "Beweish", ["/css/themes/modern.css", "/css/themes/beweish.css"], true)); | |||
| RegisterTheme(new("swarmpunk", "Swarm Punk", ["/css/themes/luminous.css", "/css/themes/swarmpunk.css"], true)); | |||
|
|
||
| /* Buttons */ | ||
| --button-text: #ffffff; /* White for button text */ | ||
| --button-background: #333333; /* Dark button background */ |
There was a problem hiding this comment.
all these inline comments are redundant... yeah it's a button-background and it's a dark color, it's already there, you don't need to repeat that
Add modern back to my first themes. Leave luminous on new ones.
src/Core/WebServer.cs
Outdated
| @@ -99,6 +99,8 @@ public void PreInit() | |||
| RegisterTheme(new("eyesear_white", "Eyesear White", ["/css/themes/eyesear_white.css"], false)); | |||
| RegisterTheme(new("swarmpunk", "Swarm Punk", ["/css/themes/modern.css", "/css/themes/swarmpunk.css"], true)); | |||
| RegisterTheme(new("beweish", "Beweish", ["/css/themes/modern.css", "/css/themes/beweish.css"], true)); | |||
| RegisterTheme(new("aquamarine", "Aquamarine", ["/css/themes/luminous.css", "/css/themes/aquamarine.css"], true)); | |||
| RegisterTheme(new("pastel", "Pastel", ["/css/themes/luminous.css", "/css/themes/pastel.css"], true)); | |||
There was a problem hiding this comment.
why do these not use modern?
There was a problem hiding this comment.
I'm submitting a new CSS stylesheet to use with these. You suggested submitting new stylesheets so I did. They have a different look and feel. Tabs are a bit different and the parameter groups are full tab sections. I can provide screenshots if needed.
There was a problem hiding this comment.
That doesn't answer my question. Yes you have your own stylesheet. You have two in fact. But why is modern not included?
There was a problem hiding this comment.
Nah, my bad I guess it wasn't registering in my head. I can add the modern style to them as well and I'll add the luminous to my swarm punk and bewish as well keeping the modern that's already on them. I think I'm up to speed now!
There was a problem hiding this comment.
Okay so both luminous and modern are being used now and they are grouped by style sheet used.
There was a problem hiding this comment.
Wh... What.
You just doubled the number of themes? And still haven't answered my question. Why is modern.css not included in the file list for the themes?
There was a problem hiding this comment.
I was trying to give people choice between the modern look and the luminous look if I add the modern.css to the themes file list then it overwrites the luminous style. Maybe I'm missing something still. The way it is there is the choice between two different styles modern and luminous. If I add modern.css and luminous.css it just makes them all modern with just a few elements of the luminous intact.
Because if you're wanting me to mix them then it's back to the drawing board because they do not play well together.
There was a problem hiding this comment.
Whatever changes luminous makes, should be made on top of modern.css. Modern is the starting point for anything developed newly like that.
There was a problem hiding this comment.
I'll have to work on that then because I'm not sure how I'll incorporate some of the stuff with both of the files being used.
|
I have edited that aquamarine file, it has the closing and the new line... it's showing odd on my side though. I click on it, it shows the correct file, I look elsewhere and it doesn't. Is it showing on your side? |
|
yeah file bottoms are good now |
Included both luminous and modern in the themes, arranged them so that they are together. Modern is together and Luminous is together and not all mixed up.
|
Marked as a draft pending Modern stylesheet usage |
Two new themes, Aquamarine and Pastel
New CSS stylesheet, Luminous
Updated my previous themes to use the new Luminous CSS sheet as intended originally.
I don't know if that will be a problem, if it is let me know and I'll just make these a new version and keep the old ones? I just didn't want to bloat it up.