feat(commuter_rail_occupancies): read commuter rail occupancies from S3 instead of firebase #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudiejd
force-pushed
the
feat/api-reads-cr-occupancy-from-s3
branch
from
ea06e8b to
5b95042
Compare
rudiejd
requested review from
a team and
lemald
and removed request for
a team
rudiejd
commented
Feb 3, 2025
| %{ | ||
| "MedianDensity" => density, | ||
| "MedianDensityFlag" => flag, | ||
| "Trip Name" => train |
lemald
reviewed
Feb 3, 2025
lemald
reviewed
Feb 3, 2025
lemald
reviewed
Feb 3, 2025
lemald
reviewed
Feb 3, 2025
lemald
reviewed
Feb 4, 2025
lemald
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s from S3
Summary of changes
Asana Ticket: 🍎 API reads Commuter Rail Occupancy from S3 instead of Firebase
Problem:
Keolis needs to decommission their Firebase feed
Solution:
We're having them move the contents of that Firebase feed to S3.
Tactically, I added
StateMediatorfor S3 that fetches files viaExAws. I made a temporary change to handle a new format (for some reasoncTrainNois relabeled asTrip Name, but I'm going to hold off on making that more permanent until I hear back from Keolis about whether this change was intentional.