Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Greentea tests if a fatal error occurs #432

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

multiplemonomials
Copy link
Collaborator

Summary of changes

Quick PR to improve quality of life for us devs! Until now, if a Greentea test obviously died (HardFault or assertion failure), the test runner would just keep on truckin', waiting for the timeout to expire before failing the test. Since some tests (esp. network ones) can have timeouts up to 20 minutes, this could result in a lot of wasted time!

With this PR, the mbed_error() handler will now output a Greentea KV pair that tells the test runner "hey, this test crashed", so it can immediately end the test.

Impact of changes

Should save some dev time during testing!

Migration actions required

Documentation

None


Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[X] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@multiplemonomials multiplemonomials merged commit b68997b into master Jan 28, 2025
52 checks passed
@multiplemonomials multiplemonomials deleted the feature/stop-test-on-error branch January 28, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants