Added ordering for dplyr locale issue. #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version 1.1.0 of dplyr, they switched to ordering
group_by
by the system locale (e.g., "English") to "C". This means that something like c("a", "b", "A", "B") would be reordered to c("A", "B", "a", "b"). This caused issues internally and produced incorrect results, when someone did not use a constant case (like "a" or "A") in their treatment variable naming.The implemented fix uses the already factored variable, rather than a version of the variable that's not a factor. So
group_by
does not have to rely on a locale to figure out the ordering.The tests for this have to intentionally set the locale to be English. This is because the C locale is automatically set for the testthat suite, meaning the test could pass, but the undesirable behavior could still occur when it's run outside of the testing suite.