🚚 Move admin overrides to other folder #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since for our e2e setup we expected the frontend build there
SilviaAmAm
force-pushed
the
fix/e2e-setup
branch
from
8abba4f to
6bde025
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #672 +/- ##
==========================================
- Coverage 89.97% 89.96% -0.01%
==========================================
Files 210 210
Lines 6116 6120 +4
Branches 647 647
==========================================
+ Hits 5503 5506 +3
- Misses 613 614 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -8,7 +8,7 @@ | |||
| {% block extrastyle %} | |||
| {{ block.super }} | |||
|
|
|||
| <link rel="stylesheet" type="text/css" href="{% static 'css/admin_overrides.css' %}"> | |||
There was a problem hiding this comment.
Do we want to limit this directory name to only css?
There was a problem hiding this comment.
At the moment we only have the css overrides 🤔 So I think we can limit it to css?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since for our e2e setup we expected the frontend build there