[maykinmedia/open-api-framework#96] Add quick-start.yml #9
Conversation
danielmursa-dev
force-pushed
the
feature/add-quick-start
branch
from
c518126 to
2090134
Compare
danielmursa-dev
force-pushed
the
feature/add-quick-start
branch
from
a240514 to
c4f1038
Compare
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Start docker containers | ||
| run: docker compose up -d --build || ( docker compose logs >&2 && exit 1; ) |
There was a problem hiding this comment.
For my information: is the explicit exit 1 needed, wouldn't the build/bringing the containers up failing cause a non zero exit code by itself? In any case I think it's fine to use this to make sure the job fails if there are any errors
There was a problem hiding this comment.
Yes it is necessary because if the build command succeeds, everything continues normally. If it fails, however, we proceed to the next part, after ||, then print the logs and exit with 1;
| done | ||
| - name: Load fixtures | ||
| if: ${{ inputs.fixtures != '' }} | ||
| run: docker compose exec -T web src/manage.py loaddata ${{ inputs.fixtures }} |
There was a problem hiding this comment.
Would it work if you pass multiple fixture names to fixtures?
There was a problem hiding this comment.
Yes it works, here there is an example: maykinmedia/open-klant#328
.github/workflows/quick-start.yml
Outdated
| SUPERUSER="${{ inputs.superuser || 'admin' }}" | ||
| WEB_SERVICE="${{ inputs.web_service || 'web' }}" |
There was a problem hiding this comment.
Since we're not testing logging in in this job, I don't think we have to make these variable, but as long as it's not required to pass them it's fine by me to leave this as is
danielmursa-dev
force-pushed
the
feature/add-quick-start
branch
from
fd189bb to
ef5dbd1
Compare
Fixes maykinmedia/open-api-framework#96