🐛 Ensure that mfa-disabled logins respect the ?next= query param #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
requested changes
Feb 27, 2024
| @@ -46,6 +46,11 @@ def get_redirect_url(self): | |||
|
|
|||
| def get_context_data(self, form, **kwargs): | |||
| context = super().get_context_data(form, **kwargs) | |||
|
|
|||
| # upstream doesn't provide a value for the "next" context variable at all | |||
| redirect_to = self.request.GET.get(self.redirect_field_name, "") | |||
There was a problem hiding this comment.
- Why isn't the redirect defined in
get_redirect_url? - Shouldn't we use
url_has_allowed_host_and_schemeto validate the redirect?
There was a problem hiding this comment.
-
get_redirect_url takes it from
request.POSTorrequest.GET, but those params are empty because they're not passed to the template during theGETphase of the form -
about
url_has_allowed_host_and_scheme- yes, this happens too when consuming the redirect URL and actually doing the URL! django-two-factor-auth behaves correctly here. I have added explicit tests for this in Open Forms too to be sure :)
There was a problem hiding this comment.
Good to know about this behavior of get_redirect_url.
pi-sigma
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this while writing tests for Open Forms.
This is actually a defect in the upstream library, I can't seem to find a place where the
nextparam would be provided to the template context.