-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/retrieve saml metadata via url #16
Merged
sergei-maertens
merged 42 commits into
master
from
feature/retrieve-saml-metadata-via-url
Oct 27, 2022
Merged
Feature/retrieve saml metadata via url #16
sergei-maertens
merged 42 commits into
master
from
feature/retrieve-saml-metadata-via-url
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6bd6ec8
to
e3a5e3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 93.78% 96.25% +2.46%
==========================================
Files 44 60 +16
Lines 2172 2880 +708
==========================================
+ Hits 2037 2772 +735
+ Misses 135 108 -27
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sergei-maertens
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Re-introduce management commands, but instead let them configure/use the solo model config classes. Any CLI flags result in the config class being overridden on the fly. Possibly we can add a
--save-config
flag to also persist that. - Regular views/SAML flows etc. should fetch config from the classes rather than from the Django setting
- Optimize the config classes so they always select_related the certificate - this query will always be done and should be avoided.
1cef1cb
to
fe1314e
Compare
digid_eherkenning/management/commands/generate_eherkenning_dienstcatalogus.py
Outdated
Show resolved
Hide resolved
digid_eherkenning/management/commands/generate_eherkenning_metadata.py
Outdated
Show resolved
Hide resolved
digid_eherkenning/management/commands/generate_eherkenning_metadata.py
Outdated
Show resolved
Hide resolved
SilviaAmAm
requested changes
Oct 21, 2022
digid_eherkenning/management/commands/generate_eherkenning_dienstcatalogus.py
Outdated
Show resolved
Hide resolved
... and use this configuration source for metadata generation. This is a squashed commit of about 8 commits by Ewen-Lgy, many thanks for the initial work.
There are some configuration params/flags that are now included that may be relevant.
* Added language option to eherkenning config * Management command now uses the eHerkenning client to generate metadata * Added EH/eidas-specific requested (additional) attributes
9c12026
to
6513ee5
Compare
And refactor the implementation to build on top of the eherkenning management command.
This has all been moved to specific management commands.
Also squashed the migrations manually to have a single config migration.
a8918aa
to
e1b1940
Compare
e1b1940
to
238b12c
Compare
Converted a number of fields into dropdowns in the admin UI by specifying the valid choices.
0f16f92
to
0fb0907
Compare
... and configure them at the URL level rather than duplicating the code and error messages.
And fix privates/sendfile setup
As the config is used at runtime too, it would be misleading to keep this part in the model names
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to ticket open-formulieren/open-forms#1849
I might not have time to close this pull request since it is my last day so here is a summary of what has been done so far and what is left to do.
DONE :
Ehekernning
andDigid
Eherkenning
,Digid
andDiesntCatalogus
metadatachange_form.html
admin template so we can have buttons (like history) to generate metadataTODO:
OIN
andmakelaar_id
in Eherkenning model)EHERKENNING
andDIGID
settings anymore (only the metadata related settings)UNDO: