[smartmodule] changes in Makefile and System Status. #129
Conversation
Makefile: ..Introducing the use of a 'usage'|'help' output to inform operations and a few useful infos. smart_module.py: ..Running mem_top() and pympler didn't get, for now, any direct information pointing to where is the memory leak. In an attempt to reduce where this leak can be, I'm commenting and changing a few pieces of code.
|
Glad to see the project is now coming back. As I always have said, this is a great project and with some hard work and time, should help a lot of people around the world. I believe the commit messages are very informative about the changes but I have expressed a few more things in the PR message area. I'm at your disposal for further information, please feel free to contact me. |
There was a problem hiding this comment.
The addition of usage info in make is useful and the use of KBytes makes things more human friendly.
Could you add the order in which the make commands have to be executed in the readme (src/smart-module/README.md)? A short list would simplify the installation process
Adding a README providing instructions for running make.
|
@moritz89 README added. At disposal for further request. |
Attention: this PR should be review in order to evaluate if the changes are desirable. These changes was proposed by me back in July, 2017 so I'm not sure if they are a good fit for now. Maybe the direction of the project has changed and these are no longer necessary.
Makefile: adding
helpandusage.smart_module.py: silly attempt to avoid unnecessary code for now, in a way to determine the memory leak as said in #60. And switching the return memory information as KBytes, rather than Bytes.