Skip to content

logger: manager: Remove hyper from console output #1033

logger: manager: Remove hyper from console output

logger: manager: Remove hyper from console output #1033

GitHub Actions / clippy succeeded Dec 1, 2023 in 0s

clippy

7 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 7
Note 0
Help 0

Versions

  • rustc 1.74.0 (79e9716c9 2023-11-13)
  • cargo 1.74.0 (ecb9851af 2023-10-18)
  • clippy 0.1.74 (79e9716 2023-11-13)

Annotations

Check warning on line 84 in src/video/video_source.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting to the same type is unnecessary (`i64` -> `i64`)

warning: casting to the same type is unnecessary (`i64` -> `i64`)
  --> src/video/video_source.rs:84:44
   |
84 |             .set_control_by_id(control.id, default_value as i64)
   |                                            ^^^^^^^^^^^^^^^^^^^^ help: try: `default_value`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
   = note: `#[warn(clippy::unnecessary_cast)]` on by default

Check warning on line 349 in src/stream/sink/udp_sink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/stream/sink/udp_sink.rs:349:59
    |
349 |             if let Err(remove_err) = pipeline.remove_many(&elements) {
    |                                                           ^^^^^^^^^ help: change this to: `elements`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 348 in src/stream/sink/udp_sink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/stream/sink/udp_sink.rs:348:56
    |
348 |         if let Err(link_err) = gst::Element::link_many(&elements) {
    |                                                        ^^^^^^^^^ help: change this to: `elements`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

Check warning on line 341 in src/stream/sink/udp_sink.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the borrowed expression implements the required traits

warning: the borrowed expression implements the required traits
   --> src/stream/sink/udp_sink.rs:341:49
    |
341 |         if let Err(add_err) = pipeline.add_many(&elements) {
    |                                                 ^^^^^^^^^ help: change this to: `elements`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

Check warning on line 314 in src/stream/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `MutexGuard` is held across an `await` point

warning: this `MutexGuard` is held across an `await` point
   --> src/stream/manager.rs:314:25
    |
314 |                     let state = match stream.state.lock() {
    |                         ^^^^^
    |
    = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
   --> src/stream/manager.rs:325:75
    |
325 |                         sinks.find(|sink| matches!(sink, Sink::Image(_))).await
    |                                                                           ^^^^^
...
333 |                             .await
    |                              ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock

Check warning on line 287 in src/stream/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `MutexGuard` is held across an `await` point

warning: this `MutexGuard` is held across an `await` point
   --> src/stream/manager.rs:287:25
    |
287 |                     let manager = match MANAGER.lock() {
    |                         ^^^^^^^
    |
    = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling await
note: these are all the `await` points this lock is held through
   --> src/stream/manager.rs:325:75
    |
325 |                         sinks.find(|sink| matches!(sink, Sink::Image(_))).await
    |                                                                           ^^^^^
...
333 |                             .await
    |                              ^^^^^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock
    = note: `#[warn(clippy::await_holding_lock)]` on by default

Check warning on line 32 in src/server/manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this async expression only awaits a single future

warning: this async expression only awaits a single future
  --> src/server/manager.rs:32:17
   |
32 |                 async { fut.await }
   |                 ^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `fut`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_async_block
   = note: `#[warn(clippy::redundant_async_block)]` on by default