Add test to check webrtc task leak #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-test-webrtc
branch
from
a0b25c0 to
d33249a
Compare
patrickelectric
force-pushed
the
add-test-webrtc
branch
3 times, most recently
from
e2d32c6 to
f61361f
Compare
src/helper/develop.rs
Outdated
Comment on lines
16
to
18
| let driver = WebDriver::new("http://localhost:9515", caps) | ||
| .await | ||
| .expect("Failed to create web driver."); |
There was a problem hiding this comment.
The port should be configurable. I can't use 9515 on my system
|
It's thread panicked here after some minutes of running: |
use crate::helper;
use core::time::Duration;
use std::thread;
use thirtyfour::prelude::*;
use tokio::runtime::Runtime;
use tracing::*;
use anyhow::Result;
async fn task(mut counter: i32) -> Result<()> {
info!("Started webrtc test..");
let mut caps = DesiredCapabilities::chrome();
let _ = caps.set_headless();
let driver = WebDriver::new("http://localhost:9516", caps)
.await
.expect("Failed to create web driver.");
driver
.goto("http://0.0.0.0:6020/webrtc/index.html")
.await
.expect("Failed to connect to local webrtc page.");
loop {
for button in ["add-consumer", "add-session", "remove-all-consumers"] {
thread::sleep(Duration::from_secs(3));
driver.find(By::Id(button)).await?.click().await?;
}
counter += 1;
info!("Restarted webrtc {} times", counter);
if helper::threads::process_task_counter() > 100 {
error!("Thead leak detected!");
std::process::exit(-1);
}
}
}
pub fn start_check_tasks_on_webrtc_reconnects() {
let counter = 0;
thread::spawn(move || {
let rt = Runtime::new().unwrap();
rt.block_on(async move {
loop {
if let Err(error) = task(counter).await {
error!("WebRTC Checker Task failed: {error:#?}");
}
}
});
error!("Webrtc test failed internally.");
std::process::exit(-1);
});
} |
Signed-off-by: Patrick José Pereira <[email protected]>
…atic tools Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
force-pushed
the
add-test-webrtc
branch
from
f61361f to
ff9fd29
Compare
please check the latest version |
joaoantoniocardoso
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's necessary to have chromedriver locally