Update to MavlinkPassthrough unsubscribe_message #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianoes
reviewed
Dec 3, 2023
src/mavsdk/plugins/mavlink_passthrough/mavlink_passthrough_impl.cpp
Outdated
Show resolved
Hide resolved
| @@ -216,7 +216,7 @@ class MavlinkPassthrough : public PluginBase { | |||
| /** | |||
| * @brief Unsubscribe from subscribe_message. | |||
There was a problem hiding this comment.
While we're at it. We should add the two @param docstrings.
…l.cpp Co-authored-by: Julian Oes <[email protected]>
|
Looks like gimbal_device_tester.cpp failed. I'll update the test. |
|
Thanks for the follow up @c-devine! Let's see if it passes now. |
julianoes
approved these changes
Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates MavlinkPassthrough to require a message id in unsubscribe_message. It fixes the bug where unsubscribing from a passthrough message also unsubscribed from messages with the same handle id but different message ids.