fix: Fixed untagged enum deserialization issues #194
Conversation
| let value = Value::deserialize(deserializer)?; | ||
| if let Ok(response) = serde_json::from_value(value.clone()) { | ||
| return Ok(Self::Response(response)) | ||
| } | ||
| use serde::de::{Error}; | ||
| Ok(Self::Event(serde_json::from_value(value.clone()).map_err(|err|Error::custom(format!("{:?}", err)))?)) |
There was a problem hiding this comment.
hmm, how is this different from untagged deserialization?
There was a problem hiding this comment.
CdpEventMessage deserialization doesn't play nice with untagged enums, i don't remember exactly why, but this adds the necessary coersion for it to work.
There was a problem hiding this comment.
maybe it was fixed in the meantime somehow, let me try on master for a bit
There was a problem hiding this comment.
it doesn't seem to be happening anymore, but longer tests are necessary
|
This looks a bit off, let me take a stab at this |
|
Let's add the This should work for a generic "fallback" type. |
|
I'm closing this as i no longer encounter the issues in the most recent version |
Fixes #167
There is maybe a better way to deserialize, but would not be as simple.