Mark Formula.differentiate as stable, and fix a regression in 1.1.0 that led to potential ordering issues in differentiated terms.
#236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…correct after v1.1.0.
matthewwardrop
force-pushed
the
matthewwardrop/issue235
branch
from
857b5e4 to
e2e5de5
Compare
matthewwardrop
added a commit
that referenced
this pull request
Dec 20, 2024
…correct after v1.1.0. (#236)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.1.0 introduced a regression in the differentiation of formulae, whereby the original order would be lost. This restores the correct behaviour, and makes
Formula.differentiateas stable.It is known the
ModelMatri[x,ces].differentiate()is still broken (in that.get_model_matrix()will fail due to structure validation), but this has been the case since pre-1.0.0. This functionality will be fixed in 1.2.0 and also marked as stable.closes: #235