A bunch of small improvements and refactorings

Api/HyvaGridArrayProviderInterface.php

@@ -11,5 +11,5 @@ interface HyvaGridArrayProviderInterface
     /**
      * @return array[]
      */
-    public function getArray(): array;
+    public function getHyvaGridData(): array;
 }

Model/Config/GridConfigReader.php

@@ -6,7 +6,7 @@
 use Magento\Framework\Config\ValidationStateInterface;
 use function array_reduce as reduce;
 
-class GridConfigReader
+class GridConfigReader implements HyvaGridConfigReaderInterface
 {
     private GridDefinitionConfigFiles $definitionConfigFiles;
 

Model/Config/HyvaGridConfigReaderInterface.php

@@ -0,0 +1,8 @@
+<?php declare(strict_types=1);
+
+namespace Hyva\Admin\Model\Config;
+
+interface HyvaGridConfigReaderInterface
+{
+    public function getGridConfiguration(string $gridName): array;
+}

Model/GridSourceType/ArrayProviderGridSourceType.php

@@ -87,7 +87,7 @@ public function fetchData(): RawGridSourceContainer
     {
         if (!isset($this->memoizedGridData)) {
             $provider               = $this->arrayProviderFactory->create($this->arrayProviderClass);
-            $this->memoizedGridData = RawGridSourceContainer::forData($provider->getArray());
+            $this->memoizedGridData = RawGridSourceContainer::forData($provider->getHyvaGridData());
         }
 
         return $this->memoizedGridData;

Test/Functional/Model/Config/GridConfigReaderTest.php

@@ -0,0 +1,20 @@
+<?php declare(strict_types=1);
+
+namespace Hyva\Admin\Test\Functional\Model\Config;
+
+use Hyva\Admin\Model\Config\GridConfigReader;
+use Hyva\Admin\Model\Config\HyvaGridConfigReaderInterface;
+use Magento\TestFramework\ObjectManager;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @magentoAppArea adminhtml
+ */
+class GridConfigReaderTest extends TestCase
+{
+    public function testIsKnownToObjectManager(): void
+    {
+        $reader = ObjectManager::getInstance()->create(HyvaGridConfigReaderInterface::class);
+        $this->assertInstanceOf(GridConfigReader::class, $reader);
+    }
+}

Test/Functional/TestingGridDataProvider.php

@@ -14,7 +14,7 @@ public static function withArray(array $testGridData): string
         return self::class;
     }
 
-    public function getArray(): array
+    public function getHyvaGridData(): array
     {
         $testGridData = self::$testGridData;
         return $testGridData;

Test/Unit/Model/GridSourceTest.php

@@ -9,6 +9,8 @@
 use Hyva\Admin\ViewModel\HyvaGrid\ColumnDefinitionInterfaceFactory;
 use PHPUnit\Framework\TestCase;
 
+use function array_map as map;
+
 class GridSourceTest extends TestCase
 {
     private function assertContainsColumn(ColumnDefinitionInterface $actual, array $columns, string $msg = ''): void
@@ -94,10 +96,26 @@ public function testMergesInIncludedColumnSpecifications(): void
             new ColumnDefinition('bar', null, 'int'), // configured type
         ];
 
-        $sut = new GridSource($gridSourceType, $stubColumnDefinitionFactory);
+        $sut              = new GridSource($gridSourceType, $stubColumnDefinitionFactory);
         $extractedColumns = $sut->extractColumnDefinitions($configuredIncludeColumns);
         $this->assertContainsColumn(new ColumnDefinition('foo', 'Foo Label', 'string'), $extractedColumns);
         $this->assertContainsColumn(new ColumnDefinition('bar', 'Bar', 'int'), $extractedColumns);
     }
 
+    public function testExtractsAllColumnKeysFromSourceIfNoneAreConfigured(): void
+    {
+        $sourceColumnKeys            = ['foo', 'bar', 'baz'];
+        $stubColumnDefinitionFactory = $this->createStubColumnDefinitionFactory();
+        $gridSourceType              = $this->createStubGridSourceType($sourceColumnKeys);
+
+        $configuredIncludeColumns = [];
+
+        $sut              = new GridSource($gridSourceType, $stubColumnDefinitionFactory);
+        $extractedColumns = $sut->extractColumnDefinitions($configuredIncludeColumns);
+        $extractedKeys    = map(function (ColumnDefinitionInterface $columnDefinition): string {
+            return $columnDefinition->getKey();
+        }, $extractedColumns);
+        $this->assertSame($sourceColumnKeys, $extractedKeys);
+    }
+
 }

etc/adminhtml/di.xml

@@ -9,6 +9,8 @@
     <preference for="Hyva\Admin\ViewModel\HyvaGrid\CellInterface" type="Hyva\Admin\ViewModel\HyvaGrid\Cell"/>
     <preference for="Hyva\Admin\ViewModel\HyvaGrid\NavigationInterface"
                 type="Hyva\Admin\ViewModel\HyvaGrid\TemporaryDummyNavigation"/>
+    <preference for="Hyva\Admin\Model\Config\HyvaGridConfigReaderInterface"
+                type="Hyva\Admin\Model\Config\GridConfigReader"/>
     <type name="Hyva\Admin\Block\Adminhtml\HyvaGrid">
         <arguments>
             <argument name="gridTemplate" xsi:type="string">Hyva_Admin::grid.phtml</argument>

readme.md

@@ -2,3 +2,13 @@
 
 This module aims to make creating grids and forms in the Magento 2 adminhtml area for developers joyful and fast.  
 It does not use any UI components.
+
+
+## next steps (a.k. todo)
+
+* implement repository source type
+* add caching to grid config reader
+* implement navigation related types
+* create schema for grid xml
+* implement collection source type
+