Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-62915 and MM-62919 #8568

Merged
merged 9 commits into from
Feb 7, 2025
Merged

MM-62915 and MM-62919 #8568

merged 9 commits into from
Feb 7, 2025

Conversation

enahum
Copy link
Contributor

@enahum enahum commented Feb 7, 2025

Summary

This PR fixes a few things:

  1. Reply to notifications on Android
  2. Sometimes we get a null pointer when ack the notification on Android, this PR should fix that as well
  3. Bleeding when switching from tabs for example from accounts to home (specially visible on tablets)
  4. Fix posts bleeding to the header when showing results on the search screen
  5. Improve performance on search results rendering by freezing the non-selected tab.
  6. Fix search results only displaying the blur images on posts.

Ticket Link

https://mattermost.atlassian.net/browse/MM-62915
https://mattermost.atlassian.net/browse/MM-62919

Release Note

NONE

@enahum enahum added 2: Dev Review Requires review by a core commiter 3: QA Review Requires review by a QA tester labels Feb 7, 2025
@enahum enahum added this to the v2.25.0 milestone Feb 7, 2025
@enahum enahum changed the title Mm 62915 mm 62919 MM-62915 and MM-62919 Feb 7, 2025
@amyblais amyblais added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Feb 7, 2025
@Willyfrog Willyfrog added Build Apps for PR Build the mobile app for iOS and Android to test and removed 2: Dev Review Requires review by a core commiter labels Feb 7, 2025
@lindalumitchell lindalumitchell added Build App for iOS Build the mobile app for iOS and removed Build Apps for PR Build the mobile app for iOS and Android to test labels Feb 7, 2025
@lindalumitchell
Copy link
Contributor

@enahum @Willyfrog looks like the iOS build failed. I'm trying just iOS again.

lindalumitchell
lindalumitchell approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@lindalumitchell lindalumitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the Android fix and the fixes listed on iPad. Nice work and thanks! 👍

@enahum enahum merged commit ee66890 into main Feb 7, 2025
15 checks passed
@mattermost-build
Copy link
Contributor

Cherry pick is scheduled.

@enahum enahum deleted the MM-62915_MM-62919 branch February 7, 2025 23:17
mattermost-build pushed a commit that referenced this pull request Feb 7, 2025
@enahum @mattermost-build
MM-62915 and MM-62919 (#8568)
49064c9 
(cherry picked from commit ee66890)
@mattermost-build mattermost-build mentioned this pull request Feb 7, 2025
Merged
@mattermost-build mattermost-build added CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone and removed CherryPick/Approved Meant for the quality or patch release tracked in the milestone labels Feb 7, 2025
enahum added a commit that referenced this pull request Feb 7, 2025
@mattermost-build @enahum
Automated cherry pick of #8568 (#8572)
b00c550 
* MM-62915 and MM-62919 (#8568)

(cherry picked from commit ee66890)

* remove duplicate backgroundColor in search results header

---------

Co-authored-by: Elias Nahum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@larkox larkox larkox approved these changes

@lindalumitchell lindalumitchell lindalumitchell approved these changes

Assignees
No one assigned
Labels
3: QA Review Requires review by a QA tester Build App for iOS Build the mobile app for iOS CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone release-note-none
Projects
None yet
Milestone
v2.25.0
Development

Successfully merging this pull request may close these issues.
7 participants
@enahum @lindalumitchell @mattermost-build @Willyfrog @larkox @amyblais @mm-cloud-bot