Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: V27 update #3580

Merged
merged 91 commits into from
Mar 7, 2025
Merged

feat!: V27 update #3580

merged 91 commits into from
Mar 7, 2025

Conversation

0xVolosnikov
Copy link
Contributor

@0xVolosnikov 0xVolosnikov commented Feb 7, 2025 •
edited by EmilLuta
Loading

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.
  • Documentation comments have been added / updated.

0xVolosnikov and others added 30 commits February 7, 2025 13:56
@0xVolosnikov
Set contracts submodule
d5bebec
@0xVolosnikov
Add new system contracts
0f37333
@0xVolosnikov
Add vm_evm_emulator vm version
557eb31
@0xVolosnikov
Update configs
0a4ec16
@0xVolosnikov
Add zk_evm_1_5_1 dependency
569e13b
@slowli
Use 0.151 VM in place of 0.150.x as well
0c8f227
@slowli
Update prover workspace deps
ddd8821
@slowli
Remove stipend for mock EVM tests
a682597
@slowli
Update vm2 version
1585b10
@slowli
Update expected circuit stats
2d40c8f
@slowli
Fix base system contracts for sandbox
aeddeb7
@slowli
Update prover lockfile
6377b2b
@slowli
Require EVM system contracts
4831747
@slowli
Update genesis state root hash
7703fa8
@slowli
Load EVM emulator in BaseSystemContracts constructors
1a1088c
@slowli
Fix ResolvedBlockInfo.use_evm_emulator
859b604
@slowli
Update from upstream
515f77d
@0xVolosnikov
Update protocol deps
678cc67
@0xVolosnikov
Update protocol deps in core
fd93069
@0xVolosnikov
Update prover components
e0f5bac
@0xVolosnikov
Update contracts
bf8ae2b
@0xVolosnikov
Add more possible path for artifacts
1035be9
@0xVolosnikov
Update verification keys
7924c4b
@0xVolosnikov
Set prover version to V27
9e1c3eb
@0xVolosnikov
Fix fflonk prover e2e test (not checkout contracts to fixed commit)
844da73
@0xVolosnikov
Update contracts
617c237
@0xVolosnikov
Update contracts
7183de2
@0xVolosnikov
Fix gateway logic in zkstack cli
4d8a11a
@zksync-admin-bot2
update GPU setup-data keys
f3c3320
@0xVolosnikov
Merge pull request #3595 from matter-labs/update-gpu-setup-data-keys-…
9b51f9f 
…4d8a11a

chore: Update generated Prover FRI GPU setup-data keys from branch evm-emulator/integration
0xVolosnikov and others added 11 commits March 5, 2025 17:15
@0xVolosnikov
Update contracts
b945b59
@0xVolosnikov
Update v26 test outputs
7037a33
@Deniallugo
fix(foundry): Support modern foundry paths (#3677)
f1d0190 
## What ❔

Support the new zksync foundry paths

## Why ❔

Foundry changed the compiled paths 

## Is this a breaking change?
- [ ] Yes
- [ ] No

## Operational changes
<!-- Any config changes? Any new flags? Any changes to any scripts? -->
<!-- Please add anything that non-Matter Labs entities running their own
ZK Chain may need to know -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.

Signed-off-by: Danil <[email protected]>
@0xVolosnikov
Use release-v27 branch of contracts
57bb72e
@0xVolosnikov
Check contracts hashes in CI
588caa1
@0xVolosnikov
Fix ci workflow
36a28fe
@0xVolosnikov
Install yarn in CI
05ec28b
@0xVolosnikov
Update contracts
86e323b
@0xVolosnikov
Merge branch 'main' into evm-emulator/integration
9ef5453
@0xVolosnikov
Update genesis config
55df229
@0xVolosnikov
Update contracts
daad885
slowli
slowli previously approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core workspace changes look good, but I may have blind spots since I've authored some of them.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Detected VM performance changes

Benchmark name Est. cycles Change in est. cycles
access_memory/legacy 13743933653 +8.7%
call_far/fast 3842365906 +445.9%
call_far/fast_no_sigs 3839262365 +447.8%
call_far/legacy 2542296697 +3.9%
decode_shl_sub/legacy 12884734726 +9.6%
deploy_simple_contract/fast 49366100 +3.2%
deploy_simple_contract/fast_no_sigs 46284099 +3.4%
deploy_simple_contract/legacy 56914559 +9.9%
event_spam/legacy 7681828741 +8.6%
finish_eventful_frames/legacy 3853414075 +5.0%
heap_read_write/legacy 11587342466 +9.4%
init/fast 14244294 +74.4%
init/fast_no_sigs 14278758 +74.1%
init/legacy 1923575 +41.4%
slot_hash_collision/legacy 13337323708 +9.3%
write_and_decode/legacy 13519370748 +9.0%

⚠ Detected differing instruction counts

Benchmark Old count New count
access_memory 4748374 4747741
call_far 319525 319501
decode_shl_sub 4748479 4747846
deploy_simple_contract 15422 15436
event_spam 2558512 2558180
finish_eventful_frames 786039 785949
heap_read_write 4252844 4252268
slot_hash_collision 4749388 4748744
write_and_decode 4749388 4748744

Changes in number of opcodes executed indicate that the gas price of the benchmark has changed, which causes it to run out of gas at a different time.

EmilLuta
EmilLuta approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@EmilLuta EmilLuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rereviewed only prover side, LGTM.

@mm-zk mm-zk added this pull request to the merge queue Mar 7, 2025
github-merge-queue bot pushed a commit that referenced this pull request Mar 7, 2025
@0xVolosnikov @slowli
@zksync-admin-bot2 @joonazan @Deniallugo
feat!: V27 update (#3580)
dd6a800 
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Code has been formatted via `zkstack dev fmt` and `zkstack dev
lint`.
- [ ] Documentation comments have been added / updated.

---------

Signed-off-by: Danil <[email protected]>
Co-authored-by: Alex Ostrovski <[email protected]>
Co-authored-by: zksync-admin-bot2 <[email protected]>
Co-authored-by: Alex Ostrovski <[email protected]>
Co-authored-by: Joonatan Saarhelo <[email protected]>
Co-authored-by: Danil <[email protected]>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2025
@mm-zk mm-zk added this pull request to the merge queue Mar 7, 2025
Merged via the queue into main with commit 9e18550 Mar 7, 2025
42 checks passed
@mm-zk mm-zk deleted the evm-emulator/integration branch March 7, 2025 11:54
This was referenced Mar 7, 2025
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli slowli left review comments

@StanislavBreadless StanislavBreadless StanislavBreadless left review comments

@EmilLuta EmilLuta EmilLuta approved these changes

@otani88 otani88 otani88 approved these changes

@perekopskiy perekopskiy perekopskiy approved these changes

@yorik yorik Awaiting requested review from yorik yorik is a code owner automatically assigned from matter-labs/devops

@alexandrst88 alexandrst88 Awaiting requested review from alexandrst88 alexandrst88 is a code owner automatically assigned from matter-labs/devops

@artmakh artmakh Awaiting requested review from artmakh artmakh is a code owner automatically assigned from matter-labs/devops

@hatemosphere hatemosphere Awaiting requested review from hatemosphere hatemosphere is a code owner automatically assigned from matter-labs/devops

@onyxet onyxet Awaiting requested review from onyxet onyxet is a code owner automatically assigned from matter-labs/devops

@iluwaa iluwaa Awaiting requested review from iluwaa iluwaa is a code owner automatically assigned from matter-labs/devops

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@0xVolosnikov @slowli @EmilLuta @otani88 @StanislavBreadless @perekopskiy @mm-zk @zksync-admin-bot2 @joonazan @Deniallugo