Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump unicode-display_width dependency #24

Merged
merged 1 commit into from
Jan 19, 2025

Conversation

jaynetics
Copy link
Contributor

The changes seem fine: https://github.com/janlelis/unicode-display_width/blob/main/CHANGELOG.md#300

I tried a few tables with complex emoji, and they seemed to render with the right width.

@@ -1,3 +1,4 @@
require "ostruct"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used in some examples; no longer automatically required in recent rubies

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling e52baec on jaynetics:bump-unicode-dependency
into e42f09d on matt-harvey:master.

Copy link
Owner

@matt-harvey matt-harvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR, @jaynetics !

@matt-harvey matt-harvey merged commit c7664e6 into matt-harvey:master Jan 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants