Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improvement] logtail: optimize the instance allocation. #21264

Closed
wants to merge 1 commit into from
Closed

[improvement] logtail: optimize the instance allocation. #21264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 24 additions & 5 deletions pkg/vm/engine/disttae/logtail_consumer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,9 +1366,10 @@ func (s *subscribedTable) setTableUnsubscribe(dbId, tblId uint64) {
type syncLogTailTimestamp struct {
timestampWaiter client.TimestampWaiter
ready atomic.Bool
tList []atomic.Value
tList []atomic.Pointer[timestamp.Timestamp]
latestAppliedLogTailTS atomic.Pointer[timestamp.Timestamp]
e *Engine
pool *sync.Pool
}

func (r *syncLogTailTimestamp) initLogTailTimestamp(timestampWaiter client.TimestampWaiter) {
Expand All @@ -1379,17 +1380,24 @@ func (r *syncLogTailTimestamp) initLogTailTimestamp(timestampWaiter client.Times

r.timestampWaiter = timestampWaiter
if len(r.tList) == 0 {
r.tList = make([]atomic.Value, consumerNumber+1)
r.tList = make([]atomic.Pointer[timestamp.Timestamp], consumerNumber+1)
}
for i := range r.tList {
r.tList[i].Store(timestamp.Timestamp{})
r.tList[i].Store(new(timestamp.Timestamp))
}
if r.pool == nil {
r.pool = &sync.Pool{
New: func() interface{} {
return &timestamp.Timestamp{}
},
}
}
}

func (r *syncLogTailTimestamp) getTimestamp() timestamp.Timestamp {
var minT timestamp.Timestamp
for i := 0; i < len(r.tList); i++ {
t := r.tList[i].Load().(timestamp.Timestamp)
t := *r.tList[i].Load()
if i == 0 {
minT = t
} else {
Expand All @@ -1410,7 +1418,18 @@ func (r *syncLogTailTimestamp) updateTimestamp(
defer func() {
v2.LogTailApplyNotifyDurationHistogram.Observe(time.Since(start).Seconds())
}()
r.tList[index].Store(newTimestamp)

// fetch the instance from the pool.
tmp := r.pool.Get().(*timestamp.Timestamp)
*tmp = newTimestamp

// get the previous instance to put it back to pool later.
prev := r.tList[index].Load()
r.tList[index].Store(tmp)

// put the previous instance to the pool.
r.pool.Put(prev)

if r.ready.Load() {
ts := r.getTimestamp()
r.timestampWaiter.NotifyLatestCommitTS(ts)
Expand Down
Loading