Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove txn reader from flush and checkpoint #20809

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aptend
Copy link
Contributor

@aptend aptend commented Dec 18, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #19474

What this PR does / why we need it:

refactor the object list and make checkpoint depend on the new object list

@aptend aptend requested a review from XuPeng-SH as a code owner December 18, 2024 06:49
@matrix-meow matrix-meow added the size/XL Denotes a PR that changes [1000, 1999] lines label Dec 18, 2024
@mergify mergify bot added the kind/refactor Code refactor label Dec 18, 2024
@aptend aptend force-pushed the remove-txn-reader-from-flush-linked-impl branch from 9388faf to 94c9d03 Compare December 18, 2024 10:14
pkg/vm/engine/tae/blockio/read.go Show resolved Hide resolved
pkg/vm/engine/tae/catalog/basemvccnode.go Outdated Show resolved Hide resolved
pkg/vm/engine/tae/catalog/basemvccnode.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/wip kind/refactor Code refactor size/XL Denotes a PR that changes [1000, 1999] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants