-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new dehydrated device format #199
Open
uhoreg
wants to merge
10
commits into
matrix-org:main
Choose a base branch
from
uhoreg:dehydration_format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+439
−16
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
fbf8e39
add support for new dehydrated device format
uhoreg 764c0d0
update OTK next ID
uhoreg 048b0f3
we also need to save the ed25519 private key
uhoreg 99be10a
make changes as requested by review, including changing encryption me…
uhoreg 00ddc18
fmt
uhoreg 6778b11
hide unused items when not using libolm-compat
uhoreg e8c1622
use unexpanded key in dehydrated device
uhoreg f234c45
add some comments
uhoreg 23d3900
use struct for dehydrated device return value
uhoreg e22dfcb
add test for unexpanded key
uhoreg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried using
Decryption(#[from] chacha20poly1305::aead::Error)
, but it was complaining about some missing traits. So I had to do this instead. I'm not sure if there's a better way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to enable the
std
feature on thechacha20poly1305
crate for this to work. It requires thestd::error::Error
trait to be defined foraead::Error
.