Update configurations to recognize dbname instead of database
#1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se name to connect to in Postgres For Synapse, these pass through and match expected configuration expectations from the manual. For Dendrite, the generated database config is parsed and turned into a DSN that is used to generate its main config yaml. All that was needed is to update where the value comes from. This brings the named parameters into line with libpq.
…nfig This only seemed to be needed for Synapse as Dendrite used another method and was not relevant
|
This is essentially matrix-org/synapse#16618, but for sytest configs. |
anoadragon453
approved these changes
Dec 19, 2024
|
(Heads up this broke sqlite synapse CI: #1392) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of a new database driver for Synapse, let's stop mutating the configuration after it's generated. Since
dbnameis what is already used by libpq and is what is expected by Synapse's configuration parsing, just use this. In Dendrite's case, it's not used directly but is parsed and turned into a DSN to feed to it's command line invocation.This does not modify the pre-existing behavior of adding an additional attribute to that part of the yaml block as it did before:
type: pgortype: sqlite, depending. It appears this is only used to identify which method to invoke to pre-clear the database before testing starts and is otherwise harmless.