Add support for the Tools->Room List api

[EionRobb]

No description provided.

[richvdh]

Looks generally good - very many thanks for your work on this. A few points:

If I try to join one of the rooms in the list, I get a segfault:

#0  strlen () at ../sysdeps/x86_64/strlen.S:106
#1  0x00007f8ca08d2b03 in g_strdup (str=0xc <error: Cannot access memory at address 0xc>) at /build/buildd/glib2.0-2.40.2/./glib/gstrfuncs.c:355
#2  0x00007f8c985841ab in matrix_connection_join_room (pc=0x7f8ca6318d40, room=0x7f8ca70707c0 "!AJUNAmUUWFTHwYVXTI:matrix.org", components=0x7f8ca72914c0) at matrix-connection.c:299
#3  0x00007f8c98582132 in matrixprpl_join_chat (gc=0x7f8ca6318d40, components=0x7f8ca72914c0) at libmatrix.c:151
#4  0x00007f8ca05c3228 in purple_roomlist_room_join () from /usr/lib/libpurple.so.0
...

matrix_connection_join_room is trying to copy the 'components' table, and treating all of the values as strings, which they are not. Any idea what the correct implementation would be here?

Would you mind fixing the indentation? We've gone with a convention of four spaces rather than tabs.

Could you add a signoff, per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off?

[richvdh]

@EionRobb: I can take this and tidy it up, but could you give me a quick Signed-off-by as per https://github.com/matrix-org/synapse/blob/master/CONTRIBUTING.rst#sign-off to satisfy the legal types?

[richvdh]

Sadly we can't take this without a signoff.

[EionRobb]

Signed-off-by: Eion Robb [email protected]

[richvdh]

Thank you :)

[ara4n]

erm, @richvdh, is there a reason not to merge?

[EionRobb]

At the moment it doesn't work with matrix.org because it's requesting https://matrix.org//_matrix/client/r0/publicRooms instead of https://matrix.org/_matrix/client/r0/publicRooms which is giving a 500 server response.

I believe I also need to fix up the whitespace?

Edit: and probably because of the segfault mentioned above :)