Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bindings): Add missing contacts field on OidcConfiguration. #2528

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Sep 7, 2023

Part of element-hq/element-x-ios#1653 and element-hq/element-x-android#1250 this PR adds the contacts field which is optional for OIDC but will become mandatory for MAS deployments.

@pixlwave pixlwave requested a review from a team as a code owner September 7, 2023 15:29
@pixlwave pixlwave requested review from Hywan and removed request for a team September 7, 2023 15:29
Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@poljar poljar enabled auto-merge (rebase) September 7, 2023 15:34
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e655490) 77.43% compared to head (bed5978) 77.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2528   +/-   ##
=======================================
  Coverage   77.43%   77.43%           
=======================================
  Files         179      179           
  Lines       19316    19316           
=======================================
  Hits        14958    14958           
  Misses       4358     4358           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit d7f5cd5 into main Sep 7, 2023
@poljar poljar deleted the doug/oidc-contacts branch September 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants