Remove workaround for matplotlib < 3.4 #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Self-merging to make a release a soon as possible. |
jenshnielsen
reviewed
Jan 2, 2025
| self.key_release_event(key, guiEvent=guiEvent) | ||
|
|
||
| handle_key_press = handle_key_release = _handle_key | ||
|
|
||
|
|
||
| class FigureManager(FigureManagerWebAgg): | ||
| if matplotlib.__version__ < "3.6": |
There was a problem hiding this comment.
Does this line not have the same issue?
There was a problem hiding this comment.
Ah yes, I missed that. It doesn't seem to cause a problem though, in my manual testing.
#580 fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #575.
Workaround code for matplotlib < 3.4 was using a string check of version number:
ipympl/ipympl/backend_nbagg.py
Line 387 in efd2e5c
which breaks using matplotlib 3.10.
It is possible to replace this with
but
__version_info__was introduced into matplotlib at version 3.5. Anyway, we no longer support matplotlib < 3.4ipympl/pyproject.toml
Line 47 in efd2e5c
so I have just removed the workaround in this PR, which fixes the problem locally for me.