updating README in preparation for matlab-actions/run-build@v2 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replacing v1 with v2
using the latest "checkout" action
mw-kapilg
reviewed
Jan 31, 2024
Comment on lines
-28
to
+24
| uses: matlab-actions/run-build@v1 | ||
| uses: matlab-actions/run-build@v2 |
There was a problem hiding this comment.
I think adding build-options to the matlab-actions/run-build action would be a MINOR release instead of a MAJOR.
There was a problem hiding this comment.
Hi, @mw-kapilg. The version bump is not due to the new option; it's because of migrating to batch tokens. In other words, this release will include your work on build options as well as @davidbuzinski 's efforts on batch tokens.
mcafaro
approved these changes
Jan 31, 2024
davidbuzinski
approved these changes
Jan 31, 2024
mw-kapilg
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.