Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify encoders to return torch.tensor and add pytests #37

Merged
merged 13 commits into from
Jan 17, 2025

Conversation

suzannejin
Copy link
Collaborator

No description provided.

Copy link
Owner

@mathysgrapotte mathysgrapotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me ! just suggested a couple of minor chages/comment changes

src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
src/stimulus/data/encoding/encoders.py Show resolved Hide resolved
Copy link
Owner

@mathysgrapotte mathysgrapotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor change, almsot there!

src/stimulus/data/encoding/encoders.py Outdated Show resolved Hide resolved
@suzannejin suzannejin merged commit d01b012 into dev Jan 17, 2025
1 of 14 checks passed
@suzannejin suzannejin deleted the encoder_return_torch branch January 17, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants