-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Volume atomic multi-slot appends. #149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just got started at the end of day today. I'll have more comments, but here's my first couple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of more comments I made yesterday and forgot to publish.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with feedback! Let me know your questions.
llfs::Volume::MultiAppend
, for atomic appending of multiple slotsIoRing
object after using it to construct anIoRing::File
would result in a dangling pointerConstBuffer
/MutableBuffer
DataReader::read_token
addedhalt()
andjoin()
member functions forLogDevice
, instead of the combinedclose()
function (now deprecated)LogDevice::prepare
may only be called once percommit
(now you can call it multiple times to progressively increase the size of the prepared buffer, provided there is space in the log)llfs::testing::TestConfig
(llfs/testing/test_config.hpp
)llfs::PageArena::close
tohalt
to be more consistent with other parts of the codeStorageSimulation
when a possible deadlock is detected (main test function has exited and there is no runnable work, but the work count on the simulation execution context is non-zero)