Adding system tests #399
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| name: using mpm to install MATLAB | ||
| on: push | ||
| jobs: | ||
| my-job: | ||
|
There was a problem hiding this comment. Could maybe give this job a more descriptive name in case we want to add more in the future. |
||
| strategy: | ||
| matrix: | ||
| os: [ubuntu-latest, windows-latest, macos-latest] | ||
| name: Run System tests | ||
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: Check out repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup Java 11 | ||
| uses: actions/setup-java@v3 | ||
| with: | ||
| java-version: '11' | ||
| distribution: 'temurin' | ||
|
|
||
|
Comment on lines
+10
to
+19
There was a problem hiding this comment. Consider updating to Also consider adding the |
||
| - name: Setup MATLAB | ||
| id: setup-matlab | ||
| uses: matlab-actions/setup-matlab@v2 | ||
|
|
||
| - name: Running tests | ||
| run: mvn verify | ||
| env: | ||
| MATLAB_ROOT: ${{ steps.setup-matlab.outputs.matlabroot }} | ||
| MLM_LICENSE_TOKEN: ${{ secrets.MLM_LICENSE_TOKEN}} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,136 +1,136 @@ | ||
|
There was a problem hiding this comment. I never noticed this before but we have separate test packages. In the Bamboo plugin we use the same package. Should the package be updated or are we going to keep them in separate packages? |
||
| package unit.com.mathworks.ci.actions; | ||
|
|
||
| /** | ||
| * Copyright 2024, The MathWorks Inc. | ||
| */ | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.io.PrintStream; | ||
| import java.nio.file.Files; | ||
|
|
||
| import org.junit.Test; | ||
| import org.junit.Before; | ||
| import org.junit.runner.RunWith; | ||
| import static org.junit.Assert.*; | ||
|
|
||
| import org.mockito.InOrder; | ||
| import org.mockito.Mock; | ||
| import org.mockito.junit.MockitoJUnitRunner; | ||
|
|
||
| import static org.mockito.ArgumentMatchers.any; | ||
| import static org.mockito.Mockito.*; | ||
|
|
||
| import hudson.FilePath; | ||
| import hudson.model.Run; | ||
| import hudson.model.TaskListener; | ||
|
|
||
| import com.mathworks.ci.MatlabBuilderConstants; | ||
| import com.mathworks.ci.BuildArtifactAction; | ||
| import com.mathworks.ci.BuildConsoleAnnotator; | ||
| import com.mathworks.ci.MatlabExecutionException; | ||
| import com.mathworks.ci.actions.RunMatlabCommandAction; | ||
| import com.mathworks.ci.utilities.MatlabCommandRunner; | ||
| import com.mathworks.ci.parameters.CommandActionParameters; | ||
|
|
||
| @RunWith(MockitoJUnitRunner.Silent.class) | ||
| public class MatlabActionTest { | ||
| @Mock | ||
| CommandActionParameters params; | ||
| @Mock | ||
| BuildConsoleAnnotator annotator; | ||
| @Mock | ||
| MatlabCommandRunner runner; | ||
| @Mock | ||
| PrintStream out; | ||
| @Mock | ||
| TaskListener listener; | ||
| @Mock | ||
| Run build; | ||
|
|
||
| @Mock | ||
| FilePath tempFolder; | ||
|
|
||
| private boolean setup = false; | ||
| private RunMatlabCommandAction action; | ||
|
|
||
| // Not using @BeforeClass to avoid static fields. | ||
| @Before | ||
| public void init() { | ||
| if (!setup) { | ||
| setup = true; | ||
| action = new RunMatlabCommandAction(runner, annotator, params); | ||
|
|
||
| when(runner.getTempFolder()).thenReturn(tempFolder); | ||
| when(tempFolder.getRemote()).thenReturn("/path/less/traveled"); | ||
|
|
||
| when(params.getTaskListener()).thenReturn(listener); | ||
| when(listener.getLogger()).thenReturn(out); | ||
|
|
||
| when(params.getBuild()).thenReturn(build); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldCopyPluginsToTempDirectory() throws IOException, InterruptedException, MatlabExecutionException { | ||
| action.run(); | ||
|
|
||
| InOrder inOrder = inOrder(runner); | ||
|
|
||
| inOrder.verify(runner) | ||
| .copyFileToTempFolder(MatlabBuilderConstants.DEFAULT_PLUGIN, MatlabBuilderConstants.DEFAULT_PLUGIN); | ||
| inOrder.verify(runner) | ||
| .copyFileToTempFolder(MatlabBuilderConstants.BUILD_REPORT_PLUGIN, | ||
| MatlabBuilderConstants.BUILD_REPORT_PLUGIN); | ||
| inOrder.verify(runner) | ||
| .copyFileToTempFolder(MatlabBuilderConstants.TASK_RUN_PROGRESS_PLUGIN, | ||
| MatlabBuilderConstants.TASK_RUN_PROGRESS_PLUGIN); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldOverrideDefaultBuildtoolPlugin() | ||
| throws IOException, InterruptedException, MatlabExecutionException { | ||
| action.run(); | ||
|
|
||
| verify(runner).addEnvironmentVariable( | ||
| "MW_MATLAB_BUILDTOOL_DEFAULT_PLUGINS_FCN_OVERRIDE", | ||
| "ciplugins.jenkins.getDefaultPlugins"); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldCopyBuildResultsToRootAndAddAction() | ||
| throws IOException, InterruptedException, MatlabExecutionException { | ||
| File tmp = Files.createTempDirectory("temp").toFile(); | ||
| tmp.deleteOnExit(); | ||
|
|
||
| File dest = Files.createTempDirectory("dest").toFile(); | ||
| dest.deleteOnExit(); | ||
|
|
||
| File json = new File(tmp, "buildArtifact.json"); | ||
| json.createNewFile(); | ||
|
|
||
| doReturn(new FilePath(tmp)).when(runner).getTempFolder(); | ||
| doReturn(dest).when(build).getRootDir(); | ||
|
|
||
| action.run(); | ||
|
|
||
| // Should have deleted original file | ||
| assertFalse(json.exists()); | ||
| // Should have copied file to root dir | ||
| assertTrue(new File(dest, "buildArtifact" + action.getActionID() + ".json").exists()); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldNotAddActionIfNoBuildResult() throws IOException, InterruptedException, MatlabExecutionException { | ||
| action.run(); | ||
|
|
||
| verify(build, never()).addAction(any(BuildArtifactAction.class)); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldRemoveTempFolder() throws IOException, InterruptedException, MatlabExecutionException { | ||
| action.run(); | ||
|
|
||
| verify(runner).removeTempFolder(); | ||
| } | ||
| } | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that we're using GitHub Actions. Does this mean we can remove the Azure Pipelines yaml?