Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome svg #2

Open
timelyportfolio opened this issue May 5, 2015 · 4 comments
Open

font-awesome svg #2

timelyportfolio opened this issue May 5, 2015 · 4 comments

Comments

@timelyportfolio
Copy link

I discovered this a couple weeks ago https://github.com/encharm/Font-Awesome-SVG-PNG, but unfortunately still does not solve the problem, since currently it seems you need something like the twemoji cdn to serve it up. It would be slow, but could just do a gh-pages branch of that repo to serve up the generated SVG.

@mathisonian
Copy link
Owner

Oh cool!

I wonder if we could use https://rawgit.com/ for this?

@timelyportfolio
Copy link
Author

rawgit, especially the cdn version, would be an option (see FAQ), but I think the gh-pages route would work better. Want me to check with the author to see if he would like to do it? If not, it is simple enough to fork and add a branch. Still none of this would be a production solution. I wonder if it would be good to add a config option to specify a url for the svg.

@mathisonian
Copy link
Owner

Yeah, that sounds good if you don't mind reaching out to them.

+1 for having a config for the URL, I was planning on adding that at some point anyways.

@timelyportfolio
Copy link
Author

since @encharm so nicely added a gh-pages branch, the url pattern will be

http://encharm.github.io/Font-Awesome-SVG-PNG/svg/*.svg

I'm thinking we will need to transform this to limit the viewBox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants