Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gh-pages branch to work with d3moji #31

Closed
timelyportfolio opened this issue May 6, 2015 · 4 comments
Closed

add gh-pages branch to work with d3moji #31

timelyportfolio opened this issue May 6, 2015 · 4 comments

Comments

@timelyportfolio
Copy link

Thanks so much for sharing this fine work. I have used the svg in multiple projects. I thought it would be nice to also make these available in d3moji (see mathisonian/d3moji#2). Would you consider adding a gh-pages branch with all the svg so that we can use them? If not, I can easily fork and do the same on my end, but I wanted to make sure you got all the credit. Thanks for considering.

If some additional information might be helfpul, see this line from d3moji to see how it accesses the svg from the twitter emoji cdn.

@Rush
Copy link
Owner

Rush commented May 6, 2015

Hi, thanks for the kind words. Yes I would definitely apply such a pull request with all the proper credits going your way for th ework. I am not too familiar with d3moji so if you require anything from me you would have to simplify it. :)

@timelyportfolio
Copy link
Author

Would it be possible for you to create an empty gh-pages branch (see this article) so I can submit a pull on that branch? I envision the pull to simply be a copy of the black svg directory as a start, so if it is easier feel free to just copy that portion, and then we won't need a pull.

Thanks again.

@Rush
Copy link
Owner

Rush commented May 6, 2015

@timelyportfolio
Copy link
Author

Thanks for this. I'll see if I can help incorporate in d3moji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants