-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
differentiation under integral #1435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenCyril
reviewed
Dec 17, 2024
I have added the gauss integral as an application of differentiation under integral |
280230e
to
4b8abd5
Compare
b02f9b6
to
c8beda2
Compare
@IshiguroYoshihiro do you have improvements to propose? |
ping? :-) |
CohenCyril
reviewed
Jan 19, 2025
CohenCyril
reviewed
Jan 19, 2025
CohenCyril
reviewed
Jan 19, 2025
CohenCyril
reviewed
Jan 19, 2025
CohenCyril
reviewed
Jan 19, 2025
063e6af
to
3d0fbd1
Compare
@CohenCyril CI's green |
ah, forgot to put |
CohenCyril
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a sec
CohenCyril
approved these changes
Feb 5, 2025
Co-authored-by: IshiguroYoshihiro <[email protected]>
Co-authored-by: Cyril Cohen <[email protected]>
9f5b63a
to
c7cea25
Compare
Many thanks for the careful review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
this can certainly be generalized but this version has already been used to prove the Gauss integral so it is maybe worth having anyway
Checklist
CHANGELOG_UNRELEASED.md
- [ ] added corresponding documentation in the headersReference: How to document
Reminder to reviewers