-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
command-7z: Add new 7-zip(7zz and 7zzs) project support #472
Conversation
Hmm, is 7zz supported by common linux distros. I see only pzip in fedora 38 (just released).
|
Ok, but can we open rar files with engrampa and p7zip after this change? |
Can decompress rar normally
There are currently no available installation packages available, but some users have chosen to manually install them, so we should add support |
Support on Debian made possible by compiling without unrar support per DSFG guidelines
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR installed and Debian's 7-zip package installed, I can create a .7z but not a .tar.7z archive, the latter regardless of attempting to compress one file or a batch. Compressing to a .7z archive works fine with a batch of files. If this is the intended behavior tar.7z should be removed from the list of options shown in caja-engrampa's "compress" menu
I can open .7z archive but i can't create a archive. No idea what's wrong here. |
@zhuyaliang
after reading file-roller commit it was clear that I would be helpful to add more comments to PR like in file-roller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lukefromdc Code update, please test again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest changes compressing to .7z produces an archive containing the files chosen, compressing to tar.7z produced a .tar file compressed with 7zip, which I am assuming to be the intended behavior and is certainly functional. Looks good to go
Add new 7Z (7zz and 7zzs) support
gnome-file-roller
#455
#450
#433
The latest version of
7zz/7zzs
supportsRAR
by default, and there is no need to determine whether it supportsRAR