Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task done #5243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Task done #5243

wants to merge 1 commit into from

Conversation

143HGS
Copy link

@143HGS 143HGS commented Jan 9, 2025

  • DEMO LINK
  • TEST REPORT LINK
  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your implementation is mostly on point, there are a few critical issues that need to be addressed before we can proceed:

  1. Universal Selector Usage: The use of the universal selector * in your CSS impacts performance and goes against the checklist guidelines. Please replace it with more specific class-based styling.

  2. File Organization: Each BEM block should have its own separate file. Currently, both the HTML and CSS for the stars block are in single files. Please organize them into separate files as per the task requirements.

  3. CSS Selector Issue: The selector .stars--0 .stars__star:nth-child(-n) is not functioning as intended. The :nth-child(-n) pseudo-class does not select any elements. Consider revising this to achieve the desired effect.

These changes are necessary to ensure the code meets the core requirements and functions as expected. Once these are addressed, we can move forward with approval. Keep up the great work, and I'm confident you'll nail it! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Comment on lines +26 to +28
.stars--0 .stars__star:nth-child(-n) {
background-image: url(/src/images/star-active.svg);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector .stars--0 .stars__star:nth-child(-n) might not work as intended. The :nth-child(-n) pseudo-class selects no elements because -n does not match any positive index. Consider using a different approach if you want to select all children.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants