Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

alla-vedmid
Copy link

  • DEMO LINK

  • TEST REPORT LINK

  • [ x] Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • [ x] All Typical Mistakes from BEM lesson theory are checked.

  • [ x] Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Hello! 😊 You've done a great job implementing the star rating system, and most of your code meets the task requirements. However, there's a critical issue with the CSS selector .html, which should be corrected to html without the dot, as html is an element, not a class. This change is necessary to ensure the styling is applied correctly. Once you address this, your solution will be in great shape! Keep up the good work, and feel free to reach out if you have any questions. 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

src/style.css Outdated
@@ -1 +1,38 @@
/* add styles here */

.html {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The selector .html is incorrect. It should be html without the dot, as html is an element, not a class. This will ensure that the margin is correctly applied to the HTML element.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the star rating system! 🌟 Your code meets most of the task requirements and constraints, and you've successfully addressed the critical issue from the previous review regarding the CSS selector correction. Here are a few points to consider for improvement:

  1. File Organization: Ensure that each BEM block has its own separate file, as this might be a requirement depending on the task description. This will help in maintaining a clean and organized codebase.

  2. Critical Issues: While there are no critical issues affecting the functionality, it's important to always verify the organization of your files and adhere to task requirements.

Your efforts are commendable, and addressing these points will further enhance your skills. Keep up the great work and continue learning from each task! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants