add task solution #5234
add task solution #5234
Conversation
There was a problem hiding this comment.
Thank you for your submission! 😊 You've done a great job with the HTML and CSS structure, and your approach to styling the stars is on the right track. However, there are a couple of critical issues that need to be addressed before we can approve your work:
-
BEM File Structure: The task requires that each BEM block has its own separate file. Currently, all styles are in a single
style.cssfile. Please separate the styles into individual files for each BEM block. -
CSS Selectors: There's a logical error in your
nth-childselectors. For example,.stars--0 .stars__star:nth-child(-n + 0)will not select any stars. You need to adjust these selectors to correctly reflect the number of active stars. For instance,.stars--0 .stars__star:nth-child(-n + 1)should be used to select the first star, and so on.
Once these issues are resolved, your code will be in great shape! Keep up the good work, and don't hesitate to reach out if you need any help. 🌟
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/style.css
Outdated
| .stars--0 .stars__star:nth-child(-n + 0), | ||
| .stars--1 .stars__star:nth-child(-n + 1), | ||
| .stars--2 .stars__star:nth-child(-n + 2), | ||
| .stars--3 .stars__star:nth-child(-n + 3), | ||
| .stars--4 .stars__star:nth-child(-n + 4), | ||
| .stars--5 .stars__star:nth-child(-n + 5) { |
There was a problem hiding this comment.
The nth-child selectors are not correctly targeting the intended number of stars. For example, .stars--0 .stars__star:nth-child(-n + 0) will not select any stars because -n + 0 results in zero, which is not a valid index. You should adjust the selectors to correctly reflect the number of active stars for each class. For instance, .stars--0 .stars__star:nth-child(-n + 0) should be .stars--0 .stars__star:nth-child(-n + 1) to select the first star, and so on.
|
fixed task |
x Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
x Each BEM block has its own separate file
x All Typical Mistakes from BEM lesson theory are checked.
x Code follows all the Code Style Rules ❗️