Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add task solution #5233

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ilona-Tkachenko
Copy link

@Ilona-Tkachenko Ilona-Tkachenko commented Jan 8, 2025

  • [DEMO LINK](https://
    Ilona-Tkachenko.github.io/layout_stars/)

  • [TEST REPORT LINK](https://
    Ilona-Tkachenko.github.io/layout_stars/report/html_report/)

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)

  • Each BEM block has its own separate file

  • All Typical Mistakes from BEM lesson theory are checked.

  • Code follows all the Code Style Rules ❗️

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is almost there, but there are a few critical issues that need to be addressed before we can approve it. 🌟

  1. HTML Structure: Each BEM block should be in its own file, as per the task requirements. This is crucial for maintaining a clean and organized codebase.

  2. CSS Selector Usage: Avoid using tag names for styling, except for html and body, to adhere to best practices.

These changes are important to meet the core requirements and ensure your code is maintainable and scalable. Keep up the great work, and once these are addressed, you'll be all set! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants