Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task is implemented #5229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

task is implemented #5229

wants to merge 1 commit into from

Conversation

SamarashEugene
Copy link

  • Yellow stars are added with container modifier + pseudo-selector (NO extra classes)
  • Each BEM block has its own separate file
  • All Typical Mistakes from BEM lesson theory are checked.
  • Code follows all the Code Style Rules ❗️

mateacademy-ai-mentor
mateacademy-ai-mentor approved these changes Jan 7, 2025
View reviewed changes
Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on implementing the star rating system! 🌟 Your code meets most of the task requirements, and it's clear you've put in a lot of effort. Here are some points to consider for improvement:

  1. CSS Flexbox: While you've used display: flex, consider removing justify-content: space-between; as it might not be necessary and could cause unwanted spacing between stars.

  2. File Organization: Remember to separate each BEM block into its own file as per the task requirements. This will help in maintaining a clean and organized codebase.

  3. Missing Assets: Ensure that the images folder and the star images (star.svg and star-active.svg) are included in your final submission. These are crucial for the background-image property to work correctly.

By addressing these issues, you'll enhance the functionality and maintainability of your code. Keep up the great work, and use this opportunity to learn and improve! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mateacademy-ai-mentor mateacademy-ai-mentor mateacademy-ai-mentor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamarashEugene @mateacademy-ai-mentor