-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add solution #5202
base: master
Are you sure you want to change the base?
add solution #5202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code is on the right track, but there are a few critical issues that need to be addressed to meet the task requirements. 🚀 Here’s what you need to focus on:
- BEM Methodology: Ensure you use BEM naming conventions for the
card
andstars
blocks, and place each in their own file. - SCSS Improvements: Implement SCSS nesting and use variables for main values, placing them in a separate file.
- Stars Block: Rewrite the
stars
block using SCSS instead of an image. - Attributes: Add the
data-qa="card"
attribute to the card block. - Card Width: Ensure the card width is set to
200px
including the border.
These changes will help align your solution with the task requirements. Keep up the great work, and feel free to reach out if you have any questions! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review
button in the Reviewers tab.
No description provided.