Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #5202

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

add solution #5202

wants to merge 10 commits into from

Conversation

ByatesEduard
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is on the right track, but there are a few critical issues that need to be addressed to meet the task requirements. 🚀 Here’s what you need to focus on:

  1. BEM Methodology: Ensure you use BEM naming conventions for the card and stars blocks, and place each in their own file.
  2. SCSS Improvements: Implement SCSS nesting and use variables for main values, placing them in a separate file.
  3. Stars Block: Rewrite the stars block using SCSS instead of an image.
  4. Attributes: Add the data-qa="card" attribute to the card block.
  5. Card Width: Ensure the card width is set to 200px including the border.

These changes will help align your solution with the task requirements. Keep up the great work, and feel free to reach out if you have any questions! 😊

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants