New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: explicit the fact the account name should be lowercase #21

Open

dehidehidehi wants to merge 1 commit into marvk:master from dehidehi-work:v1.0.1/20_explicit-accountname-should-be-lowercase

dehidehidehi commented Jan 29, 2023 •

edited

Loading

Great engine, thank you !

I would suggest making it explicit to provide a lowerCase account name when passing in the accountName into the LichessClientBuilder class.

Otherwise, the case sensitive equals() checks to determine who's turn it is (AI or player) always fails or returns null.

It was difficult for me to realize this.


          refactor: explicit the fact the account name should be lowercase

3fb2e3a

dehidehidehi mentioned this pull request

Explicit accountName must be lowercase in QueensGamBotApp.class example #20

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet