Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add MultiupMaNaGeR #2200

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add MultiupMaNaGeR #2200

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 22, 2024

Multiup MaNaGeR is a software written in Qt/C++ that can send files to the multiupload website : multiup.org.

Log: add software name--MultiupMaNaGeR
MultiupMaNaGeR

+target.path = $$PREFIX/bin
+desktop.files = misc/multiup-manager.desktop
+desktop.path = $$PREFIX/share/applications/
+icons.path = $$PREFIX/share/icons/hicolor/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

icon路径调整

Multiup MaNaGeR is a software written in Qt/C++ that can send files to the multiupload website : multiup.org.

Log: add software name--MultiupMaNaGeR
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch文件中,multiup命令的路径从/usr/bin/multiup更改为multiup,需要确认这个更改是否符合预期。
  • multiupv2.pro文件中,target.path被设置为$$PREFIX/bin,但是CONFIG变量已经被设置为embed_translations,这可能会导致问题,因为embed_translations需要将翻译文件嵌入到可执行文件中,但是target.path的更改可能不会影响这个行为。
  • desktop.filesicons.files被添加到INSTALLS中,但是没有提供这些文件的具体内容,无法判断这些更改是否正确。
  • 最后一行添加了一个--,这可能是为了表示提交结束,但是否是一个错误需要进一步确认。

是否建议立即修改:

  • 是,需要确认multiup命令的路径更改是否正确,并确保CONFIG变量的设置不会导致问题。同时,需要检查desktop.filesicons.files的添加是否正确,并确保它们的内容是正确的。最后,需要确认最后一行--的添加是否正确,并确保提交信息完整。

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kamiyadm kamiyadm merged commit a837a45 into martyr-deepin:master May 29, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants