Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add uConfig #2197

Merged
merged 1 commit into from
May 29, 2024
Merged

build: add uConfig #2197

merged 1 commit into from
May 29, 2024

Conversation

wjyrich
Copy link
Contributor

@wjyrich wjyrich commented May 21, 2024

Datasheet pinout extractor from PDF and library Stylizer for Kicad.

Log: add software name--uConfig
image

Datasheet pinout extractor from PDF and library Stylizer for Kicad.

Log: add software name--uConfig
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-install.patch文件中,存在多行相同的+开头的注释,应该删除以保持代码整洁。
  • unix块中的target.path/usr/lib更改为$$PREFIX/bin,需要确认这是否符合项目的部署要求。
  • pdf_extract.pro文件中,INCLUDEPATHDESTDIR的设置使用了$${PREFIX},这可能是一个意图上的改变,但需要确认项目是否支持这种部署模式。
  • uconfig_gui.pro文件中,target.path被设置为$$PREFIX/bin,这表明项目可能期望在用户的bin目录中安装应用程序。
  • icons.pathicons.files被设置为$$PREFIX/share/icons/hicolor/scalable/appsimg/uConfig.svg,这表明项目可能期望将图标安装到用户的icons目录中。

是否建议立即修改:

  • 是,特别是如果target.path的更改会影响到应用程序的部署路径,这可能需要与项目部署团队进行沟通。同时,删除重复的注释可以立即提高代码质量。

@kamiyadm kamiyadm merged commit c2ec2e8 into martyr-deepin:master May 29, 2024
6 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, wjyrich

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants