Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

build: add app mayo #2195

Merged
merged 1 commit into from
May 30, 2024
Merged

build: add app mayo #2195

merged 1 commit into from
May 30, 2024

Conversation

Van020530
Copy link
Contributor

3D CAD viewer and converter based on Qt + OpenCascade

log: add app

manual:
configure: |
cp images/appicon.svg images/mayoIcon.svg
cp images/appicon_16.png images/mayoIcon_16.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片名称都改成一致的

3D CAD viewer and converter based on Qt + OpenCascade

log: add app
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • patches/0001-fix-desktop-and-binary-install.patch中,新增的桌面和图标安装代码可能会覆盖现有的桌面和图标文件。需要检查是否存在冲突。
  • 新增的DESKTOP_FILE_CONTENT变量在CMakeLists.txt中没有使用,可能是未完成的代码。应该移除或完成相关功能。
  • 文件末尾的+-- 2.33.1可能是版本控制信息,但通常应该在提交消息中提供,而不是直接写在文件中。

是否建议立即修改:

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kamiyadm, Van020530

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kamiyadm kamiyadm merged commit 8f4ee19 into martyr-deepin:master May 30, 2024
6 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants